[Security Solution] Refactor rules for modularization by updating bulkCreate and wrapHits methods #101544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…076ca54526ea0e61a9a99e1c1bce854806977e
… to separate files Co-authored-by: Marshall Main <marshall.main@elastic.co> Co-authored-by: Ece Ozalp <ozale272@newschool.edu>
ecezalp
added
release_note:skip
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @ecezalp |
madirey
approved these changes
Jun 14, 2021
9 tasks
ecezalp
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 14, 2021
…kCreate and wrapHits methods (elastic#101544) creates bulkCreate and wrapHits factories for the modularization of the detection engine Co-authored-by: Marshall Main <marshall.main@elastic.co>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 14, 2021
…kCreate and wrapHits methods (#101544) (#102107) creates bulkCreate and wrapHits factories for the modularization of the detection engine Co-authored-by: Marshall Main <marshall.main@elastic.co> Co-authored-by: Ece Özalp <ozale272@newschool.edu> Co-authored-by: Marshall Main <marshall.main@elastic.co>
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Jun 15, 2021
…kCreate and wrapHits methods (elastic#101544) creates bulkCreate and wrapHits factories for the modularization of the detection engine Co-authored-by: Marshall Main <marshall.main@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
co-authored with @marshallmain
Summary
This PR creates bulkCreate and wrapHits factories and creates & injects bulkCreate and wrapHits functions into each rule executor within the detection engine from
signal_rule_alert_type.ts. The purpose of this work is to take a step towards modularized rule executors that can eventually work both within the detection engine with the existing implementation, and with the new RAC rules that are registered through the alerting framework.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers